towk/opaal
1
0
Fork 0
mirror of https://github.com/davidallendj/opaal.git synced 2025-12-20 03:27:02 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #11 from OpenCHAMI/login

Browse source 
Changed login button to use <a href> tags with no JS
This commit is contained in:
David Allen 2024-04-26 15:41:20 -06:00 • committed by GitHub
commit 890a268e11
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 18 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

32
internal/server/server.go
View file

@ -212,17 +212,19 @@ func (s *Server) StartLogin(clients []oauth.Client, params ServerParams) error {
http.Redirect(w, r, "/error", http.StatusInternalServerError) http.Redirect(w, r, "/error", http.StatusInternalServerError)
return return
} }
} else {
// perform a client credentials grant and return a token
var err error
accessToken, err = flows.NewClientCredentialsFlow(params.ClientCredentialsEndpoints, params.ClientCredentialsParams)
if err != nil {
fmt.Printf("failed to perform client credentials flow: %v\n", err)
http.Redirect(w, r, "/error", http.StatusInternalServerError)
return
}
w.Write([]byte(accessToken))
} }
// FIXME: I think this probably needs to reworked or removed
// else {
// // perform a client credentials grant and return a token
// var err error
// accessToken, err = flows.NewClientCredentialsFlow(params.ClientCredentialsEndpoints, params.ClientCredentialsParams)
// if err != nil {
// fmt.Printf("failed to perform client credentials flow: %v\n", err)
// http.Redirect(w, r, "/error", http.StatusInternalServerError)
// return
// }
// w.Write([]byte(accessToken))
// }
}) })
r.HandleFunc(callback, func(w http.ResponseWriter, r *http.Request) { r.HandleFunc(callback, func(w http.ResponseWriter, r *http.Request) {
// get the code from the OIDC provider // get the code from the OIDC provider
@ -589,10 +591,12 @@ func (s *Server) StartIdentityProvider() error {
func makeButton(url string, text string) string { func makeButton(url string, text string) string {
// check if we have http:// a // check if we have http:// a
html := "<input type=\"button\" " // html := "<input type=\"button\" "
// html += fmt.Sprintf("onclick=\"window.location.href='%s';\" ", url)
// html += fmt.Sprintf("value=\"%s\">", text)
html := "<a "
html += "class=\"button\" " html += "class=\"button\" "
html += fmt.Sprintf("onclick=\"window.location.href='%s';\" ", url) html += fmt.Sprintf("href=\"%s\">%s", url, text)
html += fmt.Sprintf("value=\"%s\">", text) html += "</a>"
return html return html
// return "<a href=\"" + url + "\"> " + text + "</a>"
} }