towk/makeshift
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

fix: issue with logging not initializing correctly

Browse source
This commit is contained in:
David Allen 2025-08-29 16:02:36 -06:00
parent e5c1b59bc1
commit 3244a66f8e
Signed by: towk
GPG key ID: 0430CDBE22619155
2 changed files with 34 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

20
cmd/root.go
View file

@ -18,7 +18,7 @@ var (
// plugins []string
// timeout int
// logFile string
logLevel logger.LogLevel = logger.INFO
loglevel logger.LogLevel = logger.INFO
)
var rootCmd = cobra.Command{
@ -32,7 +32,7 @@ var rootCmd = cobra.Command{
// initialize the logger
logFile, _ = cmd.Flags().GetString("log-file")
err = logger.InitWithLogLevel(logLevel, logFile)
err = logger.InitWithLogLevel(loglevel, logFile)
if err != nil {
log.Error().Err(err).Msg("failed to initialize logger")
os.Exit(1)
@ -67,8 +67,12 @@ func Execute() {
}
func init() {
cobra.OnInitialize(
initLogger,
// initializeConfig,
)
// initialize the config a single time
rootCmd.PersistentFlags().VarP(&logLevel, "log-level", "l", "Set the log level output")
rootCmd.PersistentFlags().VarP(&loglevel, "log-level", "l", "Set the log level output")
rootCmd.PersistentFlags().String("log-file", "", "Set the log file path (can be set with MAKESHIFT_LOG_FILE)")
}
@ -81,3 +85,13 @@ func setenv(cmd *cobra.Command, varname string, envvar string) {
cmd.Flags().Set(varname, val)
}
}
func initLogger() {
// initialize the logger
logfile, _ := rootCmd.PersistentFlags().GetString("log-file")
err := logger.InitWithLogLevel(loglevel, logfile)
if err != nil {
log.Error().Err(err).Msg("failed to initialize logger")
os.Exit(1)
}
}