refactor: changed removing secret from store returns error

pkg/secrets/localstore.go

@@ -102,10 +102,16 @@ func (l *LocalSecretStore) ListSecrets() (map[string]string, error) {
 }
 
 // RemoveSecretByID removes the specified secretID stored locally
-func (l *LocalSecretStore) RemoveSecretByID(secretID string) {
+func (l *LocalSecretStore) RemoveSecretByID(secretID string) error {
 	l.mu.RLock()
+	// Let user know if there was nothing to delete
+	_, err := l.GetSecretByID(secretID)
+	if err != nil {
+		return err
+	}
 	delete(l.Secrets, secretID)
 	l.mu.RUnlock()
+	return nil
 }
 
 // openStore tries to create or open the LocalSecretStore based on the environment

pkg/secrets/main.go

@@ -4,5 +4,5 @@ type SecretStore interface {
 	GetSecretByID(secretID string) (string, error)
 	StoreSecretByID(secretID, secret string) error
 	ListSecrets() (map[string]string, error)
-	RemoveSecretByID(secretID string)
+	RemoveSecretByID(secretID string) error
 }

pkg/secrets/staticstore.go

@@ -29,6 +29,7 @@ func (s *StaticStore) ListSecrets() (map[string]string, error) {
 	}, nil
 }
 
-func (s *StaticStore) RemoveSecretByID(secretID string) {
+func (s *StaticStore) RemoveSecretByID(secretID string) error {
-	// Nothing to do here, since nothing is being stored
+	// Nothing to do here, since nothing is being stored. With different implementations, we could return an error when no secret is found for a specific ID.
+	return nil
 }