towk/magellan
1
0
Fork 0
mirror of https://github.com/davidallendj/magellan.git synced 2025-12-20 11:37:01 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(collect): properly set secret when overriding with flags

Browse source
This commit is contained in:
Devon Bautista 2025-04-16 21:43:59 -06:00 • committed by David Allen
parent e4a521971a
commit 939be12da7
Signed by: towk
GPG key ID: 0430CDBE22619155
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
cmd/collect.go
View file

@ -91,7 +91,6 @@ var CollectCmd = &cobra.Command{
s.Password = password
}
case *secrets.LocalSecretStore:
tmpSecrets := make(map[string]string)
for k, _ := range s.Secrets {
if creds, err := bmc.GetBMCCredentials(store, k); err != nil {
log.Error().Str("id", k).Err(err).Msg("failed to get BMC credentials from secret store")
@ -106,11 +105,10 @@ var CollectCmd = &cobra.Command{
if newCreds, err := json.Marshal(creds); err != nil {
log.Error().Str("id", k).Err(err).Msg("failed to marshal updated BMC credentials")
} else {
tmpSecrets[k] = string(newCreds)
s.StoreSecretByID(k, string(newCreds))
}
}
}
store.(*secrets.LocalSecretStore).Secrets = tmpSecrets
}
}