From 722345cf938d3abc28518451ec0b4b0414641699 Mon Sep 17 00:00:00 2001 From: Devon Bautista Date: Wed, 16 Apr 2025 21:43:59 -0600 Subject: [PATCH] fix(collect): properly set secret when overriding with flags --- cmd/collect.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/cmd/collect.go b/cmd/collect.go index 3b32496..f94faf6 100644 --- a/cmd/collect.go +++ b/cmd/collect.go @@ -87,7 +87,6 @@ var CollectCmd = &cobra.Command{ s.Password = password } case *secrets.LocalSecretStore: - tmpSecrets := make(map[string]string) for k, _ := range s.Secrets { if creds, err := bmc.GetBMCCredentials(store, k); err != nil { log.Error().Str("id", k).Err(err).Msg("failed to get BMC credentials from secret store") @@ -102,11 +101,10 @@ var CollectCmd = &cobra.Command{ if newCreds, err := json.Marshal(creds); err != nil { log.Error().Str("id", k).Err(err).Msg("failed to marshal updated BMC credentials") } else { - tmpSecrets[k] = string(newCreds) + s.StoreSecretByID(k, string(newCreds)) } } } - store.(*secrets.LocalSecretStore).Secrets = tmpSecrets } }