From 6b3d31708624aa4e2a2f3e67e179b2eb32939f3a Mon Sep 17 00:00:00 2001
From: Ben McDonald <ben.mcdonald@hpe.com>
Date: Thu, 12 Jun 2025 15:25:48 -0700
Subject: [PATCH] Remove system info

---
 pkg/jaws/pdu-crawler.go  | 48 ----------------------------------------
 pkg/pdu/pdu-inventory.go |  7 ++----
 2 files changed, 2 insertions(+), 53 deletions(-)

diff --git a/pkg/jaws/pdu-crawler.go b/pkg/jaws/pdu-crawler.go
index ca4e27d..6cb3161 100644
--- a/pkg/jaws/pdu-crawler.go
+++ b/pkg/jaws/pdu-crawler.go
@@ -30,44 +30,6 @@ type JawsOutlet struct {
 	ActivePower int     `json:"active_power"`
 }
 
-// JawsSystemInfo is the struct to unmarshal /jaws/config/info/system
-type JawsSystemInfo struct {
-	Model           string `json:"model"`
-	SerialNumber    string `json:"serial_number"`
-	FirmwareVersion string `json:"firmware_version"`
-}
-
-// getSystemInfo queries the PDU for overall system details.
-func getSystemInfo(client *http.Client, config CrawlerConfig) (*JawsSystemInfo, error) {
-	targetURL := fmt.Sprintf("https://%s/jaws/config/info/system", config.URI)
-	req, err := http.NewRequest("GET", targetURL, nil)
-	if err != nil {
-		return nil, fmt.Errorf("failed to create system info request: %w", err)
-	}
-	req.SetBasicAuth(config.Username, config.Password)
-
-	resp, err := client.Do(req)
-	if err != nil {
-		return nil, fmt.Errorf("failed to execute system info request: %w", err)
-	}
-	defer resp.Body.Close()
-
-	if resp.StatusCode != http.StatusOK {
-		return nil, fmt.Errorf("received non-200 status code from system info endpoint: %d", resp.StatusCode)
-	}
-
-	body, err := io.ReadAll(resp.Body)
-	if err != nil {
-		return nil, fmt.Errorf("failed to read system info response body: %w", err)
-	}
-
-	var systemInfo JawsSystemInfo
-	if err := json.Unmarshal(body, &systemInfo); err != nil {
-		return nil, fmt.Errorf("failed to unmarshal system info: %w", err)
-	}
-	return &systemInfo, nil
-}
-
 // CrawlPDU connects to a single JAWS PDU and collects its full inventory.
 func CrawlPDU(config CrawlerConfig) (*pdu.PDUInventory, error) {
 	transport := &http.Transport{
@@ -82,16 +44,6 @@ func CrawlPDU(config CrawlerConfig) (*pdu.PDUInventory, error) {
 		Hostname: config.URI,
 	}
 
-	systemInfo, err := getSystemInfo(client, config)
-	if err != nil {
-		log.Warn().Err(err).Msgf("could not retrieve system info for %s, proceeding without it", config.URI)
-	} else if systemInfo != nil {
-		inventory.Model = systemInfo.Model
-		inventory.SerialNumber = systemInfo.SerialNumber
-		inventory.FirmwareVersion = systemInfo.FirmwareVersion
-		log.Info().Msgf("successfully collected system info from %s", config.URI)
-	}
-
 	targetURL := fmt.Sprintf("https://%s/jaws/monitor/outlets", config.URI)
 
 	req, err := http.NewRequest("GET", targetURL, nil)
diff --git a/pkg/pdu/pdu-inventory.go b/pkg/pdu/pdu-inventory.go
index 4e02972..3b0441d 100644
--- a/pkg/pdu/pdu-inventory.go
+++ b/pkg/pdu/pdu-inventory.go
@@ -7,9 +7,6 @@ type PDUOutlet struct {
 }
 
 type PDUInventory struct {
-	Hostname        string      `json:"hostname"`
-	Model           string      `json:"model,omitempty"`
-	SerialNumber    string      `json:"serial_number,omitempty"`
-	FirmwareVersion string      `json:"firmware_version,omitempty"`
-	Outlets         []PDUOutlet `json:"outlets"`
+	Hostname string      `json:"hostname"`
+	Outlets  []PDUOutlet `json:"outlets"`
 }