fix: move BMC credentials getter that logs to util func

This commit is contained in:
Devon Bautista 2025-04-16 22:42:19 -06:00 committed by David Allen
parent 939be12da7
commit 5d9afebcb1
Signed by: towk
GPG key ID: 0430CDBE22619155
5 changed files with 97 additions and 69 deletions

View file

@ -85,15 +85,17 @@ var CollectCmd = &cobra.Command{
switch s := store.(type) {
case *secrets.StaticStore:
if username != "" {
log.Info().Msg("--username passed, overriding all usernames with value")
s.Username = username
}
if password != "" {
log.Info().Msg("--password passed, overriding all passwords with value")
s.Password = password
}
case *secrets.LocalSecretStore:
for k, _ := range s.Secrets {
if creds, err := bmc.GetBMCCredentials(store, k); err != nil {
log.Error().Str("id", k).Err(err).Msg("failed to get BMC credentials from secret store")
log.Error().Str("id", k).Err(err).Msg("failed to override BMC credentials")
} else {
if username != "" {
creds.Username = username
@ -103,7 +105,7 @@ var CollectCmd = &cobra.Command{
}
if newCreds, err := json.Marshal(creds); err != nil {
log.Error().Str("id", k).Err(err).Msg("failed to marshal updated BMC credentials")
log.Error().Str("id", k).Err(err).Msg("failed to override BMC credentials: marshal error")
} else {
s.StoreSecretByID(k, string(newCreds))
}